-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add plotting functions to the experimental surface module #4235
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9c901d4
add experimental plotting module
jeromedockes a3114f9
Merge remote-tracking branch 'upstream/main' into surface-plotting
jeromedockes 41ef206
basic surface plotting function
jeromedockes 9da44f6
Merge remote-tracking branch 'upstream/main' into surface-plotting
jeromedockes 0edd273
add PolyMesh and PolyData classes, data is now stored in their `parts…
jeromedockes 50c951b
Merge remote-tracking branch 'upstream/main' into pr/jeromedockes/4235
Remi-Gau 585330f
lint
Remi-Gau c4c8da0
plot a single hemisphere and view
Remi-Gau 78559fc
fix
Remi-Gau 3da89bd
igonre tests for plotting when matplotlib is absent
Remi-Gau File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,4 +16,4 @@ | |
Use those features at your own risks! | ||
""" | ||
|
||
__all__ = ["surface"] | ||
__all__ = ["surface", "plotting"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
from ._surface_plotting import plot_surf | ||
|
||
__all__ = ["plot_surf"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
from __future__ import annotations | ||
|
||
from nilearn import plotting as old_plotting | ||
from nilearn.experimental.surface import SurfaceImage | ||
|
||
|
||
def plot_surf( | ||
img, part: str | None = None, mesh=None, view: str | None = None, **kwargs | ||
): | ||
"""Plot a SurfaceImage. | ||
|
||
TODO: docstring. | ||
""" | ||
if not isinstance(img, SurfaceImage): | ||
return old_plotting.plot_surf( | ||
surf_mesh=mesh, | ||
surf_map=img, | ||
hemi=part, | ||
**kwargs, | ||
) | ||
|
||
if mesh is None: | ||
mesh = img.mesh | ||
if part is None: | ||
# only take the first hemisphere by default | ||
part = list(img.data.parts.keys())[0] | ||
if view is None: | ||
view = "lateral" | ||
|
||
return old_plotting.plot_surf( | ||
surf_mesh=mesh.parts[part], | ||
surf_map=img.data.parts[part], | ||
hemi=part, | ||
view=view, | ||
**kwargs, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THis one need to be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do that in the follow up PR