Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] update plot_second_level_association_test.py to show some activation #4195

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Jan 8, 2024

Changes proposed in this pull request:

  • change threshold to show some activation

TODO:

  • update text

Copy link
Contributor

github-actions bot commented Jan 8, 2024

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@@ -110,13 +110,13 @@

# %%
# Let us plot the (corrected) negative log p-values for the parametric test
cut_coords = [38, -17, -3]
cut_coords = [-37, 8, -11]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to match cut coordinates of the previous figure.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9bc128) 92.11% compared to head (aaed893) 92.03%.
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4195      +/-   ##
==========================================
- Coverage   92.11%   92.03%   -0.08%     
==========================================
  Files         144      144              
  Lines       16374    16374              
  Branches     3426     3426              
==========================================
- Hits        15083    15070      -13     
- Misses        752      767      +15     
+ Partials      539      537       -2     
Flag Coverage Δ
macos-latest_3.10_test_plotting 91.89% <ø> (ø)
macos-latest_3.11_test_plotting 91.89% <ø> (ø)
macos-latest_3.12_test_plotting 91.89% <ø> (ø)
macos-latest_3.8_test_plotting 91.85% <ø> (ø)
macos-latest_3.9_test_plotting 91.86% <ø> (ø)
ubuntu-latest_3.10_test_plotting 91.89% <ø> (ø)
ubuntu-latest_3.11_test_plotting 91.89% <ø> (ø)
ubuntu-latest_3.12_test_plotting 91.89% <ø> (ø)
ubuntu-latest_3.12_test_pre 91.89% <ø> (ø)
ubuntu-latest_3.8_test_min ?
ubuntu-latest_3.8_test_plot_min 91.61% <ø> (ø)
ubuntu-latest_3.8_test_plotting 91.85% <ø> (ø)
ubuntu-latest_3.9_test_plotting 91.86% <ø> (ø)
windows-latest_3.10_test_plotting 91.87% <ø> (ø)
windows-latest_3.11_test_plotting 91.87% <ø> (ø)
windows-latest_3.12_test_plotting 91.87% <ø> (ø)
windows-latest_3.8_test_plotting 91.83% <ø> (ø)
windows-latest_3.9_test_plotting 91.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ymzayek
Copy link
Member

ymzayek commented Jan 8, 2024

Thx @Remi-Gau ! Just a suggestion to compare to the dev docs as well or instead (maybe you did locally :) just to make sure no regressions happened compared to the main branch: https://nilearn.github.io/dev/auto_examples/05_glm_second_level/plot_second_level_association_test.html#sphx-glr-auto-examples-05-glm-second-level-plot-second-level-association-test-py

@Remi-Gau Remi-Gau added the Documentation for documentation related questions or requests label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation for documentation related questions or requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plots in plot_second_level_association_test.py don't show any activation
2 participants