Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT][WIP] Add pytest-mpl unit tests to check ouput changes in plots #4123

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Nov 27, 2023

  • Closes None

This was referenced in an issue or PR but I cannot find where...

This is a suggestion to add specific tests to make sure plotting function outputs don't change accidentally.

We might not want this so this is just a very basic WIP so we can discuss it

Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8aed35) 92.00% compared to head (d19cae4) 91.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4123      +/-   ##
==========================================
- Coverage   92.00%   91.92%   -0.08%     
==========================================
  Files         145      145              
  Lines       16378    16378              
  Branches     3431     3431              
==========================================
- Hits        15069    15056      -13     
- Misses        768      779      +11     
- Partials      541      543       +2     
Flag Coverage Δ
macos-latest_3.10_test_plotting 91.78% <ø> (ø)
macos-latest_3.11_test_plotting 91.78% <ø> (ø)
macos-latest_3.12_test_plotting 91.78% <ø> (ø)
macos-latest_3.8_test_plotting 91.74% <ø> (ø)
macos-latest_3.9_test_plotting 91.75% <ø> (ø)
ubuntu-latest_3.10_test_plotting 91.78% <ø> (ø)
ubuntu-latest_3.11_test_plotting 91.78% <ø> (ø)
ubuntu-latest_3.12_test_plotting 91.78% <ø> (ø)
ubuntu-latest_3.12_test_pre 91.78% <ø> (ø)
ubuntu-latest_3.8_test_min 68.97% <ø> (ø)
ubuntu-latest_3.8_test_plot_min ?
ubuntu-latest_3.8_test_plotting 91.74% <ø> (ø)
ubuntu-latest_3.9_test_plotting 91.75% <ø> (ø)
windows-latest_3.10_test_plotting 91.76% <ø> (ø)
windows-latest_3.11_test_plotting 91.76% <ø> (ø)
windows-latest_3.12_test_plotting 91.76% <ø> (ø)
windows-latest_3.8_test_plotting 91.72% <ø> (ø)
windows-latest_3.9_test_plotting 91.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ymzayek ymzayek added the Priority: low The task is not urgent and can be delayed. label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: low The task is not urgent and can be delayed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant