Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Improve plotting contours for PlotlySurfaceFigure objects by adding add_contours method #3949

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

[ENH] Improve plotting contours for PlotlySurfaceFigure objects by adding add_contours method #3949

wants to merge 17 commits into from
+388 −5

Commits on Sep 4, 2023

  1. allow specification of linewidth in contours drawn with plotly

    @psadil
    psadil committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    a573742 View commit details
    Browse the repository at this point in the history

  2. remove extra arg from docstring

    @psadil
    psadil committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    ca73877 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. shorten line

    @psadil
    psadil committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    1c9d024 View commit details
    Browse the repository at this point in the history

  2. run flake8 on example

    @psadil
    psadil committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    fc89686 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. add tests for new methods

    @psadil
    psadil committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    4739ca0 View commit details
    Browse the repository at this point in the history

  2. delay import to avoid always requiring plotly

    @psadil
    psadil committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    8e793fb View commit details
    Browse the repository at this point in the history

  3. add test for missed method

    @psadil
    psadil committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    e395ba2 View commit details
    Browse the repository at this point in the history

  4. fix cross-reference to plotly attribute

    @psadil
    psadil committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    78bdfda View commit details
    Browse the repository at this point in the history

  5. Update nilearn/plotting/displays/_figures.py 

    Co-authored-by: Remi Gau <remi_gau@hotmail.com>
    @psadil @Remi-Gau
    psadil and Remi-Gau committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    9753884 View commit details
    Browse the repository at this point in the history

  6. Update nilearn/plotting/displays/_figures.py 

    Co-authored-by: Remi Gau <remi_gau@hotmail.com>
    @psadil @Remi-Gau
    psadil and Remi-Gau committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    ef4edf2 View commit details
    Browse the repository at this point in the history

  7. Update nilearn/plotting/displays/_figures.py 

    Co-authored-by: Remi Gau <remi_gau@hotmail.com>
    @psadil @Remi-Gau
    psadil and Remi-Gau committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    b41cd16 View commit details
    Browse the repository at this point in the history

  8. reference plotly in intersphinx

    @psadil
    psadil committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    b681315 View commit details
    Browse the repository at this point in the history

  9. import plotly at more central location, eliminating repeated imports

    @psadil
    psadil committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    e3fc2bb View commit details
    Browse the repository at this point in the history

  10. add missing cross-references

    @psadil
    psadil committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    9d12271 View commit details
    Browse the repository at this point in the history

  11. add docstring to new tests

    @psadil
    psadil committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    c256ed9 View commit details
    Browse the repository at this point in the history

  12. fix spelling

    @psadil
    psadil committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    84f9885 View commit details
    Browse the repository at this point in the history

  13. separate parameter definitions and descriptions

    @psadil
    psadil committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    cb7f960 View commit details
    Browse the repository at this point in the history