Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to set CSS class onto HTML tag of cloned document #508

Closed
wants to merge 1 commit into from

Conversation

cloakedninjas
Copy link

No description provided.

@niklasvh
Copy link
Owner

Hi @cloakedninjas!

Thanks for the PR (and +1 for including a test as well!). 0.5 already has an option callback onclone which can be used to modify the cloned document prior to it being rendered. I've added a test to illustrate how your test case could be implemented using it at:
db88784

Do you think that is sufficient to meet your needs?

@cloakedninjas
Copy link
Author

Ah I didn't see that, so yeah, this will work just as well.

Do you have a full list of options in 0.5 ?

@niklasvh
Copy link
Owner

Unfortunately not yet, will have the documentation updated before the the release of 0.5 though. (#468)

PR's for the documentation are warmly welcome as well, but understandably its harder to document something you aren't fully familiar with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants