fix: Some svg image sizes are drawn incorrectly #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppchart
force-pushed
the
master
branch
3 times, most recently
from
99390d2
to
fe02ef0
Compare
| @@ -569,16 +559,12 @@ export class CanvasRenderer extends Renderer { | |||
| } | |||
|
|
|||
| resizeImage(image: HTMLImageElement, width: number, height: number): HTMLCanvasElement | HTMLImageElement { | |||
| if (image.width === width && image.height === height) { | |||
There was a problem hiding this comment.
You are going to create a new canvas, even when the width and height are same. Maybe this is only required when image type is a SvgImageElement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When drawing some SVG images, Canvas's DrawImage Api (with 9 parameters) cannot draw the correct size
All the tests pass locally
Summary
This PR fixes/implements the following bugs/features
Explain the motivation for making this change. What existing problem does the pull request solve?
example tests/reftests/images/svg/background.html explain this bug that svg image size are drawn incorrectly
Origin:
Before:
After:
Although the size is correct, there are still some problems with the style, maybe another PR can solve the style difference of the pictures
#2904
Test plan (required)
The second svg image will draw the wrong style when using the original code in
tests/reftests/images/svg/background.html
tests/reftests/images/svg/base64.html
Closing issues
closes #2918
Fixes #