fix: add <base> to fix relative error in iframe #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can it be merged, please? |
|
Can be tested in |
nangelina
added a commit
to artificialonlinesao/html2canvas
that referenced
this pull request
Feb 9, 2024
Squashed commit of the following: commit 41fb73e Author: Frank Cheung <frank.cheung.work@outlook.com> Date: Sun Sep 25 13:13:31 2022 +0800 fix: add <base> to fix relative error in iframe
nangelina
added a commit
to artificialonlinesao/html2canvas
that referenced
this pull request
Feb 11, 2024
calling adoptNode before document.open() caused the snapshot to get cropped, so adapt the pr to only get the baseURI first, then call adoptNode and add the <base> element to it afterwards Squashed commit of the following: commit 41fb73e Author: Frank Cheung <frank.cheung.work@outlook.com> Date: Sun Sep 25 13:13:31 2022 +0800 fix: add <base> to fix relative error in iframe
|
This broke the feature on our side. We will revert this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the following bug:
Fixes #1461
Thanks.