Cleanup iframe first to prevent memory leaks, see #1609 #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can be tested in |
nangelina
added a commit
to artificialonlinesao/html2canvas
that referenced
this pull request
Feb 9, 2024
Squashed commit of the following: commit 96cc89a Author: yuyuyzl <yuzhongliang221@gmail.com> Date: Tue Sep 6 10:36:07 2022 +0800 fix: cleanup iframe first to prevent memory leaks, see niklasvh#1609 commit 485a49e Author: yuyuyzl <yuzhongliang221@gmail.com> Date: Tue Sep 6 10:28:22 2022 +0800 fix: cleanup iframe first to prevent memory leaks, see niklasvh#1609
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following bugs/features
I'm working on a PNG sequence rendering project, and I was trying to use this for lightweight rendering (heavyweight ones should use headless chrome based project like Remotion)
About 200 frames can be rendered well, and then the page got out ouf memory and crashed.
With a heap snapshot, it is clear that "Detached window" consumes most of the memory.
Tried to clean up iframes and remove it manually in the promise resolve, it works very well, the memory usage of Chrome barely increases after that, and I can render 2000+ frames at once.
See #1609 for the detailed cleanup code.
Test plan (required)
You may need a heavy dom tree with some datasrc images to speedup the memory leaks.
Then, call html2canvas repeatedly, monitor Chrome's memory usage in taskmgr, or until it crashes.
Code formatting
Please make sure that code adheres to the project code formatting. Running
npm run formatwill automatically format your code correctly.Sure.
Closing issues
Fixes #1609