Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiline + text wrap support for textarea #261

Closed
wants to merge 1 commit into from

Conversation

thomasttvo
Copy link

resolve #259

@thomasttvo thomasttvo closed this Aug 15, 2013
@thomasttvo thomasttvo reopened this Aug 15, 2013
@fotrino
Copy link

fotrino commented Oct 2, 2013

baotamvo, how can i use it? Thank you!

@thomasttvo
Copy link
Author

You can clone the main repo and merge this fix then compile the project. The result is that it would help html2canvas render textareas correctly when a html2canvas read a dom with textareas.

@fotrino
Copy link

fotrino commented Oct 3, 2013

Can you explain how can i compile the project? I'm new to this. Thank you!

@niklasvh niklasvh closed this Oct 16, 2014
@moxet
Copy link

moxet commented Feb 10, 2015

I am still facing the same problem with the latest build, how to fix multiple lines?

@thomasttvo
Copy link
Author

@moxet try the fix that I submitted in this pull request. You need to apply it manually though.

@moxet
Copy link

moxet commented Feb 11, 2015

@thomasttvo Sorry to bother you but i have limited knowledge of solving it manually. I don't have the structure of parse.js and others. I have html2canvas.js file only. Where can i make the changes?

@thomasttvo
Copy link
Author

sorry @moxet, I've over looked the fact that this file was far out of date. The new html2canvas code is very different now, so my changes wouldn't help you with this.

@charles-dexter-ward
Copy link

line-height with a value of normal is not taken into consideration. It should be calculated in some way based on the font. Not so simple because every browser has its own method to calculate the line-height when it is setted as "normal".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants