Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL support for html2canvas #1222

Conversation

nicholasgonzalezsc
Copy link

@nicholasgonzalezsc nicholasgonzalezsc commented Sep 19, 2017

This PR is based off of the solution found here #686 (comment)

Also related: #948

@niklasvh
Copy link
Owner

Thanks for the PR! I'll need some time to look through and get a better understanding of RTL in general, as I am not very familiar of how it works, how https://developer.mozilla.org/en-US/docs/Web/CSS/direction impacts it, as well as https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/dir

@mehdi-mashayekhi
Copy link

hi please fix this problem and add to html2canvas

@idolizesc
Copy link

@niklasvh Do you think you'll get a chance to look at this and integrate it?

@niklasvh niklasvh force-pushed the master branch 3 times, most recently from 932773c to 1584357 Compare December 3, 2017 10:23
@sep8
Copy link

sep8 commented May 11, 2018

I am very concerned about when this problem can be solved.

@neda-kiya
Copy link

@niklasvh
when this problem can be solved :-( lots of problem in RTL or persian

@kinging123
Copy link

@niklasvh any news about this? 😢

@mohafouad
Copy link

any updates :(

@Avishaidev
Copy link

any updates?

@akryeem
Copy link

akryeem commented Jan 13, 2020

Any updates on letters splitting?

@zohardnl
Copy link

hi,
when this pr will be merged ?

@ghonchesefidi
Copy link

Any update?

Copy link

@hasanparasteh hasanparasteh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding Persian/Farsi in your SUPPORTED_RTL_CATEGORIES list

@chaim-chv
Copy link

any updates?
current version doesn't support RTL languages.. this is so disappointing 🤕

@niklasvh
Copy link
Owner

RTL support added in #2653

@niklasvh niklasvh closed this Aug 14, 2021
@ghonchesefidi
Copy link

@niklasvh Thanks for your effor. Good job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet