Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte component testing #19

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

harshit-bs
Copy link
Member

No description provided.

index.d.ts Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/utils/injectScript.js Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@harshit-bs
Copy link
Member Author

harshit-bs commented Aug 9, 2023

These build failures are occurring due to the importScript command (written for vue), which returns a Selenium WebElement instead of Nightwatch's extended webElement, causing missing methods like find.

cc @vaibhavsingh97

@harshit-bs harshit-bs marked this pull request as ready for review August 10, 2023 08:17
@harshit-bs
Copy link
Member Author

harshit-bs commented Aug 10, 2023

Though svelte has written, they support node 14.18.x in their package.json. But in the recent updates, they have used performance (introduced in node v16.0) here and btoa (introduced in node v15.13.0) here which causing error for svelte component tests in node v14. But working fine in node >=16.0

And as discussed we will remove support v14, so I have upgraded node versions in CI workflow only. Let me know if I should add engines in package.json also or we will take this call later.

cc @AutomatedTester

@AutomatedTester
Copy link
Member

And as discussed we will remove support v14, so I have upgraded node versions in CI workflow only. Let me know if I should add engines in package.json also or we will take this call later.

Yes please update that too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants