Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change param name to avoid CUDA solvers runtime error: "nonLinearIter… #150

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

zhangxaochen
Copy link

…ations" -> "nIterations", "linearIterations" -> "lIterations"

since this commit: f96f626#diff-4ec1b09480d2efd4ac57e2db04ec1bdd

the param names have been changed in examples/shape_from_shading/src/CombinedSolver.h

@Mx7f
Copy link
Collaborator

Mx7f commented Jun 18, 2019

Happy to merge the first 3 commits; but the last two seem to be one-off tests.

@zhangxaochen
Copy link
Author

Thanks for your reply~

I don't quite understand the words one-off tests (not use the PR quite often...), could u explain it a bit?

Does that mean I should close this PR and create another one which contains only the first 3 commits?

BTW, I have one more question on the dimlist parameter of Graph (#140 (comment)). Could you take some time to answer it?

Thank you very much~~~~ :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants