Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of generated SIFT features #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stotko
Copy link

@stotko stotko commented Oct 30, 2018

While playing around with the SIFT feature extractor, I observed the following problems:

  • When creating the keypoint list, the flag bHasMax is defined the wrong way which would lead to unexpected behaviour in no limit is set. If there is a limit, then too many features are copied, but this is handled implicitly later on making this hard to recognize.

  • I observed that in many cases the number of extracted features (at least what is returned by GetFeatureNum()) exceed the specified limit. The function LimitFeatureCount() removes overflowing levels iteratively until the count would drop below the limit in the next iteration. This is fixed by partially removing this last contributing level to match the limit.

  • Although the feature extraction limit can be controlled in the config file, the Bundler uses a hard-coded number of 150. Since the value in the config file is 1024, the above errors were unfortunately not catched. The second commit adjusts the config file and removes the hard-coded value.

… one and adjust it in the config file to preserve current behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant