-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/docker minecraft support #30
base: master
Are you sure you want to change the base?
Feature/docker minecraft support #30
Conversation
Thanks for your PR! A couple questions:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #30 +/- ##
===========================================
- Coverage 100.00% 99.64% -0.36%
===========================================
Files 1 1
Lines 284 285 +1
===========================================
Hits 284 284
- Misses 0 1 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
No the rcon-cli is only reachable inside the container and not meant to be exposed. It has no password. The only purpose of the rcon-cli is sending commands into the server runnint inside the container.
Because that would not work with a multi server setup. I have 8 servers running on my host and use a loop to go though all my servers. In order to keep configuration minimal by only entering a screen/container name and the path, all servers need the same configuration and the same rcon-cli access method. Also I want to avoid exposing the rcon-cli to my host network. I trust my firewall, but human errors are still the biggest threat. Also exposing the port would increase maintainability work on the host since I need to make sure to not reuse ports used by another server. Simply executing the commands via docker exec is the less errorprone way and also the easiest. |
Thanks! That makes sense. Although I am pretty sure rcon-cli will ask for a password if there is an rcon password configured for your Minecraft server. Here's what I see for mine:
This PR looks good. I'll merge once we have a test for this case. If I have some free time I'll work a bit on creating one. |
This patch adds support for the https://github.com/itzg/docker-minecraft-server docker image when using bin mounts.
Commands are executed via the integrated rcon-cli. The screen name is used as the container name