Minor code updates #183
Open
Minor code updates #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after using kirimase, the following tend to be errors based on biome ♦ update strings returned as a concatenated string rather than a string with a variable added ♦ import types updated ♦ strongly typed if statements
♦ defaultValues are now instead set to field values or empty string, this will remove any possible incompatible null vs unassigned
♦ when defaulting to Input fields: `<Input {...field} />`, an error occurs of incompatible field values, so deconstructing the value to `value={field.value || ''}` solves this error
|
added more minor updates from errors faced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated several minor imports, and code snippets used in kirimase, making it less likely for errors and more type safe where I could find.