Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pipeline functionality and made minor fixes #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DBremen
Copy link

@DBremen DBremen commented Sep 8, 2019

Hi Nicholas,
thanks a lot for the great module. I've made some changes and hope that you might find them useful:
Get-Histogram

  • Added DefaultDisplayPropertySet (Index,Count,lowerBound,upperBound)
  • Made function take input from pipeline (not processing by pipeline but just as syntactic sugar)
  • Replaced arraylist "pipeline data collector" by automatic $Input variable
  • Changed gh alias to ghist (collided with Get-Help for me)
  • Cannot get the test "Honors minimum and maximum values" working (mock call to write-warning)

Add-Bar

  • Fixed double selection of Count property
  • Changed name of InputObject to Data for consistency
  • Replaced arraylist "pipeline data collector" by automatic $Input variable

Measure-Object

  • Made function take input from pipeline (not processing by pipeline but just as syntactic sugar)

Show-Measurement

  • Made function take input from pipeline (not processing by pipeline but just as syntactic sugar)
  • Changed name of InputObject to Data for consistency
  • Could not get the 'Produces output' test working (mock call to write-host)
  • Decreased width to account for text in front of graph

Dirk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant