Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transform source bug #1918

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Fix transform source bug #1918

merged 5 commits into from
Mar 12, 2024

Conversation

fredvisser
Copy link
Contributor

Pull Request

🤨 Rationale

Fixes #1913 by using js-beautify instead of prettier: ^3 in transformSource.js.

👩‍💻 Implementation

  1. Leverage a popular code formatting tool - https://www.npmjs.com/package/js-beautify
  2. Used the default formatting settings, as they looked correct to me.

🧪 Testing

Manual review of Storybook docs pages.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@fredvisser
Copy link
Contributor Author

fredvisser commented Mar 11, 2024 •
edited by rajsite

moved to thread

@rajsite rajsite marked this pull request as ready for review March 11, 2024 22:18
@rajsite rajsite requested a review from jattasNI as a code owner March 11, 2024 22:18
@rajsite rajsite enabled auto-merge (squash) March 12, 2024 16:30
@rajsite rajsite merged commit d8aa87d into main Mar 12, 2024
12 checks passed
@rajsite rajsite deleted the users/fvisser/add-beautify-source branch March 12, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsite rajsite rajsite approved these changes

@jattasNI jattasNI Awaiting requested review from jattasNI jattasNI is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency update PR broke Storybook source snippets
2 participants
@fredvisser @rajsite