feat: allow deep links in redirectTo validation #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onehassan
force-pushed
the
feat/oauth-redirect-deep-link
branch
from
a4bb915
to
59e3665
Compare
|
Please, can you add tests for the new schemas supported? Also, same for the go bit (file |
dbarrosop
reviewed
May 6, 2024
onehassan
force-pushed
the
feat/oauth-redirect-deep-link
branch
from
b67a013
to
98d8ab3
Compare
onehassan
force-pushed
the
feat/oauth-redirect-deep-link
branch
from
98d8ab3
to
f8240bd
Compare
dbarrosop
reviewed
May 20, 2024
| case url.endsWith('/**'): | ||
| break; | ||
| case url.endsWith('/*'): | ||
| url += '*'; |
There was a problem hiding this comment.
will this modify the original string?
There was a problem hiding this comment.
this will mutate the url but here we're just looping through a copy of AUTH_ACCESS_CONTROL_ALLOWED_REDIRECT_URLS and so the array of the allowed redirect urls won't be mutated
dbarrosop
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.