New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: subdividing a type of grid event handler #2003

Open

AshtonYoon wants to merge 1 commit into nhn:master from AshtonYoon:refactor/grid-event-with-type

AshtonYoon commented Dec 24, 2023

Please check if the PR fulfills these requirements

It's submitted to right branch according to our branching model
It's right issue type on title
When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
The commit message follows our guidelines
Tests for the changes have been added (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)
It does not introduce a breaking change or has description for the breaking change

Description

Parameter types of event handlers have been subdivided by event name.
Can see at the editor level what data to handle in the event handler.

Extract types from GridEventProps

AS-IS

TO-BE

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨


          refactor: subdividing a type of grid event handler

2fd2cfa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment