Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null check for common.ts/assign #1947

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pmingkr
Copy link

@pmingkr pmingkr commented Jul 26, 2023

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

if the dataSource failed to response on sorting, it's errored on firing the errorResponse event.
eventBus.ts/createEventBus/trigger method uses setInstance method with the tui.Grid instance.
but the tui.Grid instance contains null at grid.store.data.filters.
and eventually it calls common.ts/assign with null value.
So I added null-check for it on this PR.


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant