Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: frozenBorder not repositioning in safari (fix #1882) #1901

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bi-kim
Copy link

@bi-kim bi-kim commented Apr 5, 2023

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • If the parent's left margin value changes, the child's coordinate values should change as well. However, there is a bug
    when Safari calculates the position between these elements, which can cause the margins to shrink. (margin collapse)

As-Is
https://user-images.githubusercontent.com/10782883/230027834-011830aa-1ab7-4aab-87e3-a5786f237856.mov

To-Be
https://user-images.githubusercontent.com/10782883/230027888-ed4362ae-dc4b-4b2b-8ddd-133f9bc25f91.mov


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@bi-kim bi-kim marked this pull request as draft April 5, 2023 09:01
@bi-kim bi-kim marked this pull request as ready for review April 5, 2023 09:02
@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant