bam::Record:new should return a valid record

See rust-bio#339.
nh13 · Jun 17, 2022 · 4db8850 · 4db8850
1 parent b130634
commit 4db8850
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/bam/record.rs b/src/bam/record.rs
@@ -113,12 +113,19 @@ fn extranul_from_qname(qname: &[u8]) -> usize {
 impl Record {
     /// Create an empty BAM record.
     pub fn new() -> Self {
-        Record {
+        let record = Record {
             inner: unsafe { MaybeUninit::zeroed().assume_init() },
             own: true,
             cigar: None,
             header: None,
         }
+        // Developer note: these are needed so the returned record is properly
+        // initialized as unmapped.
+        record.set_tid(-1);
+        record.set_pos(-1);
+        record.set_mpos(-1);
+        record.set_mtid(-1);
+        record
     }
 
     pub fn from_inner(from: *mut htslib::bam1_t) -> Self {