fix(TranslateService): load translations if they have not been loaded before (#1193)(#1266) #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfmeretzki
changed the title
|
When this gonna be added? Its a blocking issue. |
Franky238
approved these changes
Mar 7, 2022
Franky238
approved these changes
Mar 7, 2022
Franky238
approved these changes
Mar 7, 2022
|
Sad that library seems to be abandoned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains no breaking changes.
When the
translateService.use(...)method is called nothing happens if the current language is the same as the one passed as parameter. This causes that after changing the language in one instance of the translate service the rest of instances don't fetch the translations if they don't use isolate = true since the current language is the same as the one passed as parameter. That is why workarounds like thisworked. Removing the first return statement leaves the service check if it has the translations and gets them if they have not been loaded before. It fixes (#1193)(#1266) between other issues I am not able to find now.