Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add *translateContext & *translateNamespace directives #1358

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

FortinFred
Copy link

This PR contains no breaking changes:

Extract from README.md.

7. Use translate namespace:

You can namespace your keys using the *translateNamespace structural directive

<ul *translateNamespace="'somApp.pageX.contentComponent'">
  <li translate>key1</li>
  <li translate>key2</li>
  <li translate>key3</li>
</ul>

Would translate the somApp.pageX.contentComponent.key1, somApp.pageX.contentComponent.key2 and somApp.pageX.contentComponent.key3 keys.

The namespaces directive are also stackable:

// app.component.html
<div *translateNamespace="'someApp'">
  <router-outlet></router-outlet>
</div>
// pageX.component.html
<div *translateNamespace="'pageX'">
  <content-component></content-component>
</div>
// content.component.html
<ul *translateNamespace="'contentComponent'">
  <li translate>key1</li>
  <li translate>key2</li>
  <li translate>key3</li>
</ul>

Note:

To avoid breaking changes, the translation resolution will fallback to a non namespaced key if the key isn't found in a given namespace.

8. Use translate context:

You can use the *translateContext structural directive to provide the context of all child translation to avoir to repeat the translateParams directive.

{
  "person": {
    "bio": {
      "nameColumn": "{{firstName}} {{lastName}}",
      "addressColumn": "{{address}} {{city}} {{state}}",
      "age": "{{age}} years old"
    }
  }
}
<ul *translateContext="person">
  <li translate>person.bio.nameColumn</li>
  <li translate>person.bio.addressColumn</li>
  <li translate>person.bio.age</li>
</ul>

The context are also stackable. Meaning that context from parent dom element will be inherited and merged with the current context.

Since *translateNamespace and *translateContext are structural directives and Angular limits one structural directive per element, it is possible to provide the namespace on the *translateContext directive:

<ul *translateContext="person; namespace: 'person.bio' ">
  <li translate>nameColumn</li>
  <li translate>addressColumn</li>
  <li translate>age</li>
</ul>

@FortinFred
Copy link
Author

@ocombe I would like some feedback on this feature.
Thx

@maciej-pawlisz
Copy link

@FortinFred translate-context.service is missing from this PR :)

@FortinFred
Copy link
Author

@FortinFred translate-context.service is missing from this PR :)

How silly of me! Just pushed it.
The service extends the translate-service which might not be disirable?! Not sure. I had to make it like this to make it work in a non ngx-translate repo.

It's kind of a hack but it makes it seperated.

Let me know.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants