Update signal-state.ts #4291
Closed
Update signal-state.ts #4291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export type for usage.
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
| @@ -2,7 +2,7 @@ import { signal } from '@angular/core'; | |||
| import { STATE_SIGNAL, StateSignal } from './state-signal'; | |||
| import { DeepSignal, toDeepSignal } from './deep-signal'; | |||
|
|
|||
| type SignalState<State extends object> = DeepSignal<State> & StateSignal<State>; | |||
| export type SignalState<State extends object> = DeepSignal<State> & StateSignal<State>; | |||
There was a problem hiding this comment.
Could you give a use case where you require this type?
We try to expose as little as possible to lower the surface of future breaking changes to types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export type for usage.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the type is not exported.
Closes #
What is the new behavior?
Exports the type for usage in app.
Does this PR introduce a breaking change?
Other information