Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): export TypedAction #4183

Closed
wants to merge 1 commit into from

Conversation

NathanLaing
Copy link
Contributor

Export TypedAction from Store

Closes #4136

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[X] Other... Please describe:

API change - exports new type

What is the current behavior?

No export

Closes #4136

What is the new behavior?

Exports TypedAction

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Export TypedAction from Store

Closes ngrx#4136
Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit fc784ee
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/657c9c3a88ee040008d916cf

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @NathanLaing
We're currently looking into another fix to resolve this issue.
That's why we haven't merged this in.

I'll keep this PR open for now, it can be approved or closed later.

@markostanimirovic
Copy link
Member

closing this PR in favor of #4318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can TypedAction be exported from @ngrx/store?
4 participants