Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can TypedAction be exported from @ngrx/store? #4136

Closed
2 tasks
trevorade opened this issue Nov 17, 2023 · 1 comment · Fixed by #4318
Closed
2 tasks

Can TypedAction be exported from @ngrx/store? #4136

trevorade opened this issue Nov 17, 2023 · 1 comment · Fixed by #4318

Comments

@trevorade
Copy link

trevorade commented Nov 17, 2023 •
edited

Which @ngrx/* package(s) are relevant/related to the feature request?

store

Information

@ngrx/store exports Action but not TypedAction from:

platform/modules/store/src/models.ts

Line 8 in b5385db

export declare interface TypedAction<T extends string> extends Action {

There is no documentation why TypedAction should be internal only.

There are several projects that import it by reaching into the source file:

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@trevorade
Copy link
Author

Alternatively, TypedAction could be deleted in favor of:

export interface Action<T extends string = string> {
  readonly type: T;
}

NathanLaing pushed a commit to NathanLaing/platform that referenced this issue Dec 15, 2023
@nathanlaingzigzag
feat(store): export TypedAction
fc784ee 
Export TypedAction from Store

Closes ngrx#4136
@NathanLaing NathanLaing mentioned this issue Dec 15, 2023
Closed
3 tasks
@timdeschryver timdeschryver mentioned this issue May 7, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@trevorade