fix(typings): correctly unpack values of nested form group arrays #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Minor fix for existing tying of
ValuesOf
for nestedFormArray<FormGroup>
.What is the current behavior?
Assuming the following FormType:
When using
ValuesOf<ControlsOf<FormType>>
thetags
has the typeFormControl<string[]>
instead ofstring[]
.Issue Number: N/A
What is the new behavior?
The typing now correctly unpacks the values of FormGroup nested in FormArrays.
Does this PR introduce a breaking change?
Users might encounter a breaking change if they have the above scenario AND rely on the current incorrect typing. Fixing resulting errors is likely low effort
Other information