docker-compose localstack #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NetanelBasal pls kindly review |
|
It does not work without it? I think the default is all services |
|
Yes you're right the default is all service, |
|
No. I would like to have a live example in the code. For example: https://www.zeolearn.com/magazine/uploading-files-to-aws-s3-using-nodejs |
|
Okay will do my best |
|
@NetanelBasal pls kindly check it out and review |
|
|
harellevy
reviewed
Jul 24, 2022
Comment on lines
+7
to
+16
| const BUCKET_NAME = "nxboy"; | ||
|
|
||
| const s3 = new AWS.S3({ | ||
| region: "us-east-1", | ||
| accessKeyId: KEY_ID, | ||
| secretAccessKey: SECRET_KEY, | ||
| endpoint: 'http://localhost:4566', // This is the localstack EDGE_PORT | ||
| s3ForcePathStyle: true, | ||
| }); | ||
|
|
There was a problem hiding this comment.
very specific s3 bucket? what's the intention here?
There was a problem hiding this comment.
@harellevy just an example to create a localstack s3 bucket
harellevy
reviewed
Jul 24, 2022
localstack-s3/upload.js
Outdated
Comment on lines
30
to
50
| // const uploadFile = (filename) => { | ||
| // const filecontent = fs.readFileSync(filename); | ||
|
|
||
| // const params = { | ||
| // Bucket: BUCKET_NAME, | ||
| // Key: "", | ||
| // Body: filecontent, | ||
| // ContentType: "" | ||
| // } | ||
|
|
||
| // s3.upload(params,(err, data)=>{ | ||
| // if(err){ | ||
| // console.log(err) | ||
| // } | ||
| // else{ | ||
| // console.log("File uploaded successfully", data.Location) | ||
| // } | ||
| // }) | ||
| // } | ||
|
|
||
| // uploadFile("") |
There was a problem hiding this comment.
okay i will
Thanks
|
@NetanelBasal pls kindly review and revert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NetanelBasal resolved #2 just added s3 to the env on docker-compose file
