Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system: provide a way to pass additional options to cmake invoc… #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thresheek
Copy link

@thresheek thresheek commented Dec 20, 2023

…ation.

When building otel module as a part of nginx build system process (via ./configure --add-dynamic-module=nginx-otel/), there is no way to pass additional options to the cmake invocation, making it impossible link the module with desired ssl library variant.

With the patch, it's now possible to pass the additional options, e.g. NGINX_OTEL_ADDITIONAL_OPTS="-DOPENSSL_ROOT_DIR=/usr/lib64/openssl11;/usr/include/openssl11" ./configure --add-dynamic-module=nginx-otel/, and cmake will pick up the correct ssl variant to link the module with.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

…ation.

When building otel module as a part of nginx build system process (via
./configure --add-dynamic-module=nginx-otel/), there is no way to pass
additional options to the cmake invocation, making it impossible link
the module with desired ssl library variant.

With the patch, it's not possible to pass the additional options, e.g.
NGINX_OTEL_ADDITIONAL_OPTS="-DOPENSSL_ROOT_DIR=/usr/lib64/openssl11;/usr/include/openssl11"
./configure --add-dynamic-module=nginx-otel/, and cmake will pick up the
correct ssl variant to link the module with.
@p-pautov
Copy link
Contributor

I believe, cmake looks for OPENSSL_ROOT_DIR in environment variables as well. So does setting it as an environment variable directly works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants