Use standard way to build a module and avoid cmake usage #11

osokin · 2023-09-17T20:31:21Z

Proposed changes

Proposal of these changes is to:

use standard way, i.e. --add-module or --add-dynamic-module configure options to build a module;
avoid cmake(1) usage.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING document
If applicable, I have added tests that prove my fix is effective or that my feature works
If applicable, I have checked that any relevant tests pass after adding my changes
I have updated any relevant documentation (README.md and CHANGELOG.md)

The proposal of this change is to remove cmake(1) from the module build process.

Use `s/gHttpModule/ngx_otel_module/g' to make the module linkable. Update library dependency list with `-lgrpc++' to fix build.

- remove needless src/modules.c, that generates by nginx build system - rename the module's source file to src/ngx_otel_module.cpp

Please visit for details: nginxinc#16

(cherry picked from commit 958a4b6)

Move on to gRPC v1.46.7 and opetelemtry-cpp v1.11.0, last versions that support C++11. (cherry picked from commit fa280e1)

(cherry picked from commit 7edca7a)

(cherry picked from commit 0491cc0)

(cherry picked from commit c8c7168)

Removed documentation task, as most of it is hosted externally for now. (cherry picked from commit aac5678)

(cherry picked from commit b54c650)

(cherry picked from commit 93dc2b1)

Starting with 2023-06-01 RE2 publicly depends on Abseil, so we can't use system provided RE2 together with gRPC-bundled Abseil. (cherry picked from commit fa28f37)

(cherry picked from commit d6d7ce1)

(cherry picked from commit 5a0071f)

Incidentally, this also removes RE2 code from the binary. (cherry picked from commit 30b9b73)

(cherry picked from commit d381713)

to resolve the following error during the load module on nginx' start up: undefined symbol "_z11initgrpclogv"

osokin added 3 commits September 16, 2023 12:52

WIP: make nginx-otel module cmake-free

f58abc0

The proposal of this change is to remove cmake(1) from the module build process.

WIP: make nginx-otel module cmake-free

dc52126

Use `s/gHttpModule/ngx_otel_module/g' to make the module linkable. Update library dependency list with `-lgrpc++' to fix build.

Simplify build:

1222d06

- remove needless src/modules.c, that generates by nginx build system - rename the module's source file to src/ngx_otel_module.cpp

osokin force-pushed the no-cmake branch from c3c90e7 to 1222d06 Compare September 20, 2023 00:34

osokin mentioned this pull request Oct 5, 2023

Ability to statically build the module #9

Open

osokin and others added 15 commits December 14, 2023 18:36

Fix build with protobuf v22+

ae5dbab

Please visit for details: nginxinc#16

Prevent crash for HTTP/0.9 requests (fix nginxinc#22).

8f0857d

(cherry picked from commit 958a4b6)

Bump gRPC and opentelemetry-cpp versions.

6dc30a0

Move on to gRPC v1.46.7 and opetelemtry-cpp v1.11.0, last versions that support C++11. (cherry picked from commit fa280e1)

Removed NOTICE, it's covered by README.md and LICENSE already.

39142c1

(cherry picked from commit 7edca7a)

Add manual run of actions.

11622d3

(cherry picked from commit 0491cc0)

Update commit message guidelines.

346036f

(cherry picked from commit c8c7168)

Update PR template.

7e674ab

Removed documentation task, as most of it is hosted externally for now. (cherry picked from commit aac5678)

Move gRPC/Protobuf logs handling to a dedicated file.

ed031aa

(cherry picked from commit b54c650)

Use Abseil logging for Protobuf v22 and above (fix nginxinc#16).

b845bf4

(cherry picked from commit 93dc2b1)

Stop using system provided RE2 for static build.

be044de

Starting with 2023-06-01 RE2 publicly depends on Abseil, so we can't use system provided RE2 together with gRPC-bundled Abseil. (cherry picked from commit fa28f37)

Bump gRPC to v1.49.4 to support building with GCC 13 (fix nginxinc#13).

91e6d13

(cherry picked from commit d6d7ce1)

Enforce compiler warnings in CI build only.

cbf01a6

(cherry picked from commit 5a0071f)

Disable unnecessary gRPC features to reduce binary size.

e6fa953

Incidentally, this also removes RE2 code from the binary. (cherry picked from commit 30b9b73)

Fix undefined symbols error on Mac (fix nginxinc#38).

79f05c2

(cherry picked from commit d381713)

Update the module's configuration...

0b9db0a

to resolve the following error during the load module on nginx' start up: undefined symbol "_z11initgrpclogv"

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use standard way to build a module and avoid cmake usage #11

Use standard way to build a module and avoid cmake usage #11

osokin commented Sep 17, 2023 •

edited

Use standard way to build a module and avoid cmake usage #11

Are you sure you want to change the base?

Use standard way to build a module and avoid cmake usage #11

Conversation

osokin commented Sep 17, 2023 • edited

Proposed changes

Checklist

osokin commented Sep 17, 2023 •

edited