Fix crdPath in automated tests when applying the crd directory #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
approved these changes
Apr 26, 2024
ciarams87
approved these changes
Apr 29, 2024
sjberman
reviewed
Apr 29, 2024
sjberman
approved these changes
Apr 29, 2024
bjee19
force-pushed
the
fix/apply-crd-directory-correctly
branch
from
da5e133
to
24b127b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: After modifying the crds path, the automated upgrade test would error when trying to apply the crds:
Solution: Add a trailing slash to the crdPath.
Testing: Automated upgrade test no longer errors on this section.
Closes
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.