Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NAP build stages to use AppProtect Release 4.9.0 #5498

Closed
wants to merge 5 commits into from
Closed

Update NAP build stages to use AppProtect Release 4.9.0 #5498

wants to merge 5 commits into from

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented May 3, 2024 •
edited

Proposed changes

This PR:

  • updates our NAP build stages to install the latest version of the App Protect Packages (Release 4.9.0 in this case)
  • is intended to verify our integration tests still pass on this new version of App Protect

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the docker Pull requests that update Docker code label May 3, 2024
@shaun-nx shaun-nx mentioned this pull request May 3, 2024
Closed
@shaun-nx shaun-nx changed the title POC - WAF v4.9 Update NAP build stages to use AppProtect Release 4.9.0 May 3, 2024
@shaun-nx shaun-nx marked this pull request as ready for review May 3, 2024 10:56
@shaun-nx shaun-nx requested a review from a team as a code owner May 3, 2024 10:56
@shaun-nx
Merge branch 'main' into poc/waf-v4.9
8e4d8b6 
Signed-off-by: Shaun <s.odonovan@f5.com>
@shaun-nx shaun-nx added the R32 label May 7, 2024
@nginx-bot nginx-bot removed the R32 label May 13, 2024
@shaun-nx shaun-nx linked an issue May 15, 2024 that may be closed by this pull request
Update NAP build stages to use AppProtect Release 4.10 #5556
Closed
@shaun-nx
Copy link
Contributor Author

Closing this PR as these changes since we'll be jumping to NGINX R32 + NAP v4.10 instead.

New PR here will have those changes + changes from this PR

@shaun-nx shaun-nx closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@oseoin oseoin Awaiting requested review from oseoin

@vepatel vepatel Awaiting requested review from vepatel

Assignees
No one assigned
Labels
docker Pull requests that update Docker code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update NAP build stages to use AppProtect Release 4.10
4 participants
@shaun-nx @jjngx @pdabelf5 @nginx-bot