Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add policies count to telemetry #5457

Merged
merged 12 commits into from Apr 29, 2024
Merged

Add policies count to telemetry #5457

merged 12 commits into from Apr 29, 2024

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

Add policies count to telemetry + tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested review from a team as code owners April 26, 2024 15:55
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements documentation Pull requests/issues for documentation go Pull requests that update Go code labels Apr 26, 2024
ADubhlaoich
ADubhlaoich approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc change (and correction!) LGTM but the majority of this PR is code-based, so I will not approve.

@shaun-nx shaun-nx self-requested a review April 29, 2024 13:40
jjngx
jjngx approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jjngx jjngx changed the title Add policies count to telemetry + tests Add policies count to telemetry Apr 29, 2024
@AlexFenlon AlexFenlon merged commit 7232b9f into main Apr 29, 2024
78 checks passed
@AlexFenlon AlexFenlon deleted the feat/telemetry-policy-count branch April 29, 2024 14:11
@AlexFenlon AlexFenlon linked an issue Apr 29, 2024 that may be closed by this pull request
Collect count of Policies #5142
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect count of Policies
5 participants
@AlexFenlon @ADubhlaoich @j1m-ryan @jjngx @shaun-nx