Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test code gen #5455

Closed
wants to merge 1 commit into from
Closed

test code gen #5455

wants to merge 1 commit into from

Conversation

haywoodsh
Copy link
Contributor

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@haywoodsh haywoodsh changed the title test chmod test code gen Apr 26, 2024
@github-actions github-actions bot added bug An issue reporting a potential bug chore Pull requests for routine tasks labels Apr 26, 2024
@haywoodsh
test chmod
690257d 
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
pdabelf5
pdabelf5 reviewed Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@pdabelf5 pdabelf5 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the script doesn't need to be executable when running with

bash <script> <options>

specifying bash is forcing it to use that shell

@haywoodsh haywoodsh closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 left review comments

Assignees
No one assigned
Labels
bug An issue reporting a potential bug chore Pull requests for routine tasks
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haywoodsh @pdabelf5