Fix nginx breaking & remove unused code for ProxySetHeaders annotation #5426

AlexFenlon · 2024-04-18T14:53:37Z

This fixes nginx breaking if certain characters was in the value and removing unused code in configmaps.

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have checked that all unit tests pass after adding my changes
I have updated necessary documentation
I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Fix invalid character in value & remove unused code

d430e3a

AlexFenlon requested a review from a team as a code owner April 18, 2024 14:53

AlexFenlon self-assigned this Apr 18, 2024

github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code labels Apr 18, 2024

Simplify to allow for 1 restriction

ac2133c

j1m-ryan approved these changes Apr 26, 2024

View reviewed changes

jjngx approved these changes Apr 26, 2024

View reviewed changes

AlexFenlon added 2 commits April 26, 2024 15:58

Merge branch 'main' into fix/proxy-set-headers-annotation-bugs

3e5bd65

Merge branch 'main' into fix/proxy-set-headers-annotation-bugs

14b3f5a

haywoodsh approved these changes Apr 26, 2024

View reviewed changes

Merge branch 'main' into fix/proxy-set-headers-annotation-bugs

8dc5327

AlexFenlon merged commit 6a69e8d into main Apr 29, 2024
78 checks passed

AlexFenlon deleted the fix/proxy-set-headers-annotation-bugs branch April 29, 2024 07:58

Provide feedback