values: auto-generate leaderElectionLockName by default #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for nginx-kubernetes-ingress pending review.Visit the deploys page to approve it
|
github-actions
bot
added
tests
The README claims that it's auto-generated today, but it's actually hard-coded. By changing it to use an empty string by default, the `nginx-ingress.leaderElectionName` helper will take care of auto-generating it. Finally, make sure `nginx-ingress.leaderElectionName` is used in the RBAC Role instead of the hard-coded value. Fix nginxinc#5389 Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
kyrofa
force-pushed
the
bugfix/5389/auto-generate-leaderElectionLockName
branch
from
11151bb
to
dd8c35c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README claims that it's auto-generated today, but it's actually hard-coded. This PR fixes #5389 by changing it to use an empty string by default, thereby allowing the
nginx-ingress.leaderElectionNamehelper to take care of auto-generating it.