Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm] Choose NodePort values for controller.service.type = LoadBalancer #5335

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Falltrades
Copy link

@Falltrades Falltrades commented Apr 2, 2024

Proposed changes

Closes related issue: #5333

This changes enable the possibility to choose custom NodePort port values when for controller.service.type = LoadBalancer.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@Falltrades Falltrades requested a review from a team as a code owner April 2, 2024 19:27
Copy link

netlify bot commented Apr 2, 2024

👷 Deploy request for nginx-kubernetes-ingress pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4bb9882

@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

[Helm] Choose NodePort values for controller.service.type = LoadBalancer
1 participant