Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update nap logconf CRD #5273

Merged
merged 6 commits into from Apr 29, 2024
Merged

update nap logconf CRD #5273

merged 6 commits into from Apr 29, 2024

Conversation

galitskiy
Copy link
Contributor

Proposed changes

  • update range for APlogconf CRD max_request_size (1-10240, or 1-10k)
  • remove unused nap log-default.json
  • update some fields for APpolicy CRD (remove indentation to match NAP CRDs)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@galitskiy galitskiy requested a review from a team as a code owner March 19, 2024 19:34
@netlify Netlify
Copy link

netlify bot commented Mar 19, 2024 •
edited

👷 Deploy request for nginx-kubernetes-ingress pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ebbf6ee

@brianehlert brianehlert added this to the v3.6.0 milestone Mar 19, 2024
@brianehlert brianehlert added change Pull requests that introduce a change backlog Pull requests/issues that are backlog items labels Mar 19, 2024
@vepatel vepatel linked an issue Mar 25, 2024 that may be closed by this pull request
Update nap-waf logconf CRD #5305
Closed
@github-actions github-actions bot added docker Pull requests that update Docker code and removed change Pull requests that introduce a change labels Apr 18, 2024
@vepatel vepatel merged commit 327f6fc into nginxinc:main Apr 29, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
backlog Pull requests/issues that are backlog items docker Pull requests that update Docker code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

Update nap-waf logconf CRD
4 participants
@galitskiy @vepatel @jjngx @brianehlert