Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CertManager handle errors registering the EventHandler #5227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CertManager handle errors registering the EventHandler #5227

wants to merge 1 commit into from

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Mar 8, 2024 •
edited

Proposed changes

CertManager controller should handle errors registering the EventHandler

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner March 8, 2024 17:23
jjngx
jjngx approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
NGINX Ingress Controller
Status: Todo ☑
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pdabelf5 @jjngx