Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transportserver-template config #5194

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add transportserver-template config #5194

wants to merge 7 commits into from
+34 −3

Conversation

ssrahul96
Copy link
Contributor

@ssrahul96 ssrahul96 commented Mar 4, 2024 •
edited

Proposed changes

Created custom-template Config for TransportServer

Fixes #5459

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ssrahul96 ssrahul96 requested a review from a team as a code owner March 4, 2024 03:59
@netlify Netlify
Copy link

netlify bot commented Mar 4, 2024 •
edited

👷 Deploy request for nginx-kubernetes-ingress pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3b3eae4

@ssrahul96 ssrahul96 requested a review from a team as a code owner March 4, 2024 04:06
@ssrahul96 ssrahul96 changed the title Draft: Added transportserver-template config Added transportserver-template config Mar 4, 2024
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 4, 2024
@ssrahul96 ssrahul96 changed the title Added transportserver-template config Add transportserver-template config Mar 4, 2024
ADubhlaoich
ADubhlaoich reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM docs-wise but the majority of the PR is code, so I will not approve.

@ssrahul96
Copy link
Contributor Author

Team, Could it be reviewed and merged?

@j1m-ryan
Copy link
Member

j1m-ryan commented Apr 25, 2024 •
edited

Hi @ssrahul96 , can you create an issue for this, and attach it to this PR?
You can read about this process in CONTRIBUTING.md

@github-actions github-actions bot added the go Pull requests that update Go code label Apr 27, 2024
ssrahul96 and others added 3 commits May 7, 2024 21:15
@ssrahul96 @j1m-ryan
Update docs/content/configuration/global-configuration/configmap-reso…
53cee1e 
…urce.md

Co-authored-by: Jim Ryan <j.ryan@f5.com>
Signed-off-by: Rahul Somasundaram <rahulstsgr@gmail.com>
@ssrahul96 @j1m-ryan
Update examples/shared-examples/custom-templates/README.md
828971e 
Co-authored-by: Jim Ryan <j.ryan@f5.com>
Signed-off-by: Rahul Somasundaram <rahulstsgr@gmail.com>
@ssrahul96
Merge branch 'main' into trasnport-server-template
3b3eae4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianehlert brianehlert brianehlert left review comments

@ADubhlaoich ADubhlaoich ADubhlaoich left review comments

@j1m-ryan j1m-ryan j1m-ryan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation go Pull requests that update Go code
Projects
NGINX Ingress Controller
Status: Todo ☑
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Trasnportserver Template
4 participants
@ssrahul96 @j1m-ryan @brianehlert @ADubhlaoich