New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evolve oidc logout #4986
base: main
Are you sure you want to change the base?
Evolve oidc logout #4986
Conversation
👷 Deploy request for nginx-kubernetes-ingress pending review.Visit the deploys page to approve it
|
Thank you @llomgui |
Thank you @llomgui for submitting. Would it be possible for you to submit a GitHub issue to describe the situation you are trying to address. See CONTRIBUTING.md for a description of the issue submission process. There is also the scheduled community call where issues can be discussed. |
Hello @pdabelf5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the docs side. Withholding from an approval since much of the PR is code-based.
Hi @llomgui, We reviewed your issue and the team recommendation is to get the contents of your PR and port it into the Open ID connect reference implementation |
@danielnginx I will create a PR on this repository. Do I have to close this one? I don't see any link with Kubernetes-ingress. |
@llomgui thank you. Once that PR is merged in the nginx-openid-connect, files should get copied over to https://github.com/nginxinc/kubernetes-ingress/tree/main/internal/configs/oidc via a PR. You can close this PR for now. |
@danielnginx The PR created on OIDC repository does not include operators changes. |
@llomgui you are right, we can leave this PR open. Once we get the nginx-openid-connect PR in we can update here. |
@danielnginx Do you have any news on this PR? |
As @danielnginx said, we can merge this PR as soon as your PR in the nginx-openid-connect repo is approved and merged. If you need more visibility on PR, you can post about it in the public #nginx-users slack channel. The maintainers of the nginx-openid-connect repo frequently monitor that channel. |
Proposed changes
Make sure the IDP is triggered during a logout.
Checklist
Before creating a PR, run through this checklist and mark each as complete.