Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable VS backup service tests #4947

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Re-enable VS backup service tests #4947

wants to merge 13 commits into from

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Jan 19, 2024

Proposed changes

Re-enable VS backup service Python tests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the tests Pull requests that update tests label Jan 19, 2024
@jjngx jjngx marked this pull request as ready for review January 19, 2024 13:33
@jjngx jjngx requested a review from a team as a code owner January 19, 2024 13:33
pdabelf5
pdabelf5 reviewed Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@pdabelf5 pdabelf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to poll to see if the required changes have taken place, rather than have lots of hardcoded waits?

@shaun-nx shaun-nx self-requested a review February 6, 2024 17:23
@shaun-nx shaun-nx linked an issue Feb 7, 2024 that may be closed by this pull request
backup server in upstream for VirtualServer and TransportServer not removed when the backup services is deleted #4774
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 left review comments

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
stale Pull requests/issues with no activity tests Pull requests that update tests
Projects
NGINX Ingress Controller
Status: Todo ☑
Milestone
No milestone
3 participants
@jjngx @pdabelf5 @shaun-nx