Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be logged out on IDP side #4989

Open
llomgui opened this issue Jan 26, 2024 · 1 comment · May be fixed by #4986
Open

Be logged out on IDP side #4989

llomgui opened this issue Jan 26, 2024 · 1 comment · May be fixed by #4986
Labels
backlog candidate Pull requests/issues that are candidates to be backlog items proposal An issue that proposes a feature request

Comments

@llomgui
Copy link

llomgui commented Jan 26, 2024

Is your feature request related to a problem? Please describe.
With the current oidc configuration, if you go on https://domain.org/logout, it only clears the cookies from Nginx perspective, not from IDP.
As describe in Auth0 documentation, you need to redirect the user on IDP's logout endpoint.

Describe the solution you'd like
The solution is to redirect the user on IDP's logout endpoint with the correct arguments.
On the IDP side, you can specify the Nginx logout endpoint /_logout and then Nginx will redirect to a final page https://domain.org/login.

Nginx teams already done that in a previous project. Not implemented on this one.
https://github.com/nginx-openid-connect/nginx-oidc-auth0/blob/main/oidc.js#L178
https://github.com/nginx-openid-connect/nginx-oidc-auth0/blob/main/oidc_nginx_server.conf#L132

@llomgui llomgui added the proposal An issue that proposes a feature request label Jan 26, 2024
Copy link

Hi @llomgui thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@llomgui llomgui linked a pull request Jan 26, 2024 that will close this issue
6 tasks
@danielnginx danielnginx linked a pull request Jan 29, 2024 that will close this issue
6 tasks
@danielnginx danielnginx added the backlog candidate Pull requests/issues that are candidates to be backlog items label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog candidate Pull requests/issues that are candidates to be backlog items proposal An issue that proposes a feature request
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants