fix: include a complete fastcgi_params config

[buchdag]

Rebase of #2011 by @rodrigoaguilera

Should fix #1466

[buchdag]

@rodrigoaguilera @tkw1536 I'm really unfamiliar with PHP-FPM, before I merge this could you explain to me what is the effect of

fastcgi_param  SCRIPT_FILENAME    $document_root$fastcgi_script_name;

because this additional line is the only difference between the fastcgi_params and the fastcgi.conf files.

By merging this, isn't it possible that we break setup that worked with fastcgi_params but won't with fastcgi.conf ?

I've also seen this mentioned as a possible fix instead of the former line in #1466:

fastcgi_param  SCRIPT_FILENAME    $request_filename;

Is it the same ?

[rodrigoaguilera]

The SCRIPT_FILENAME in fastcgi.conf is more complete and it is suited for more complex apps such as Drupal, WordPress or Laravel.

The variation that only uses $request_filename might be enough for apps that work with a single index.php without request query arguments.
http://nginx.org/en/docs/http/ngx_http_core_module.html#variables

Using $fastcgi_script_name is better since it takes care of things like adding index.php to the variable passed onto the fpm engine.
https://nginx.org/en/docs/http/ngx_http_fastcgi_module.html

I see a remote chance of breaking if someone specified in their nginx fastcgi_params and then the include the fastcgi.conf to overwrite those but I regard that as highly unlikely.

Thank you for keeping the project maintained.

[rodrigoaguilera]

Looks good to me.

[buchdag]

Thanks for the explanation, seems safe to merge to me 👍