feat: allow nginx / docker-gen network segregation #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Knapoc
force-pushed
the
network-segregation-seperate-containers
branch
from
858ee87
to
8bcb1c7
Compare
Knapoc
force-pushed
the
network-segregation-seperate-containers
branch
from
8bcb1c7
to
5ed66ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to allow for network segregation of the nginx and docker-gen containers in a separate container setup.
As of now this is not possible as it is assumed, that docker-gen and nginx are attached to the same networks.
In case
docker-gen would set the server to a fallback-entry within the upstream directive.
This behavior is changed with this PR when the nginx-container is known to docker-gen (by having a label applied). In this case the fallback-entry is only set, when the backend is not available to nginx.