build: get forego from pre-built image #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buchdag
added
the
type/build
rhansen
approved these changes
May 11, 2023
|
Just FYI we went from ~16 minutes build time to ~2 minutes build time by using pre built docker-gen and forego. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much the same as #2230 but for forego, which now have a pre built image (
nginxproxy/forego).The diff between version
0.17.0and0.17.1is pretty much just dependencies maintenance and the new Dockerfiles + GitHub Action workflow required for the images building and publishing.I don't plan on doing any work on forego beside this and the occasional dependencies bump, so this PR aim is mostly to further simplify nginx-proxy Dockerfiles and get yet another small bump in build speed.