Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remote backends via VIRTUAL_IP #2234

Closed
wants to merge 1 commit into from

Conversation

f403
Copy link

@f403 f403 commented May 5, 2023

This adds support for non-container upstreams (e.g. somewhere on LAN).
Some time ago I used a patch from #1100 to solve this issue, but current template has changed a lot.
Although running a dummy container for each custom upstream is a bit hacky, but it keeps same approach for all deployments, implements a feature requested many times, and does this with minimal changes in the template.

This PR may potentially close:

Related PRs (some may be hard to merge now, if they are old):

@buchdag buchdag added status/pr-needs-tests This PR needs new or additional test(s) type/feat PR for a new feature labels May 7, 2023
@buchdag
Copy link
Member

buchdag commented May 8, 2023

Hi.

Thanks for the PR.

Unfortunately while I do understand that's a wanted feature, my answer from mid 2021 still stands: this is out of the original stated scope of this project, and I don't see it implemented using zombie containers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/pr-needs-tests This PR needs new or additional test(s) type/feat PR for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants