feat: New eval function to evaluate a template
#485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the idea behind this PR to modularise the nginx-proxy template instead of using more and more |
|
The idea is to make it easier to modularize. Technically it's currently possible to use templates as functions, but the return value has to be stored in the template's dot dict instead of the more natural/readable approach of writing it out. (See nginx-proxy/nginx-proxy#1938 for an example.) |
This makes it possible to:
* modularize a template by using an embedded template (defined with
Go's built-in `define` action) as a function whose return value is
the expansion of the template
* post-process the expansion of a template (e.g., pipe it to
Sprig's `indent` function)
For additional context, see
<golang/go#54748>. Sprig is unlikely to add
an equivalent to this function any time soon: the function must be a
closure around the template, meaning either Sprig or Go would have to
change its API.
buchdag
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to:
defineaction) as a function whose return value is the expansion of the templateindentfunction)For additional context, see golang/go#54748. Sprig is unlikely to add an equivalent to this function any time soon: the function must be a closure around the template, meaning either Sprig or Go would have to change its API.