Implement Issue api endpoint. #184
Conversation
you can only reference issues via their iid. https://code.ogdsoftware.nl/help/api/issues.md#single-issue https://code.ogdsoftware.nl/help/api/issues.md#edit-issue https://code.ogdsoftware.nl/help/api/issues.md#delete-an-issue assignee column is deprecated.
there are some calls that do not return an object. for instance the remove issue endpoint. this is needed to implement remove-gitlabprojectissue
demeesterdev
changed the title
pester asks for whatif and confirm help
There was a problem hiding this comment.
This is a great addition.
PSGitLab.Format.ps1xml: No changes needed.
QueryGitLabAPI.ps1: I think the HasResults should be dropped from the QueryGitLabAPI function.
PSGitLab.psd1: Revert back to the master and add your functions only.
Get-GitLabProjectIssue.ps1: No changes needed.
Move-GitLabProjectIssue: No Changes needed.
New-Gitlabprojectissue: No changes needed.
Remove-Gitlabprojectissue: see comment.
Set-Gitlabprojectissue.ps1: no changes needed.
| @@ -8,65 +8,65 @@ | |||
|
|
|||
| @{ | |||
|
|
|||
| # Script module or binary module file associated with this manifest. | |||
| RootModule = 'PSGitLab.psm1' | |||
| # Script module or binary module file associated with this manifest. | |||
There was a problem hiding this comment.
Lots of whitespace issues in this upload. Keep the changes limited to the FunctionsToExport
| Method = 'DELETE' | ||
| } | ||
|
|
||
| QueryGitLabAPI -Request $Request -NoResult |
There was a problem hiding this comment.
Instead of a NoResult, just put the output of QueryGitLabAPI into a variable and simply don't return it.
This leaves a passthru parameter as a future enhancement.
| Position=0)] | ||
| [ValidateNotNullOrEmpty()] | ||
| $Request, | ||
| [cmdletbinding(DefaultParameterSetName = "HasResults")] |
There was a problem hiding this comment.
I don't think the HasResults is necessary.
|
It is my fault that there are so many whitespace issues. @it-praktyk cleaned up the code and I was way too slow to accept the changes that I already reviewed. You will likely need to pull again from master to solve the merge conflict. Let me know if you need any help. |
|
Also, @tdemeester if there is any code you think we're missing from GitLab-API feel free to bring it in! |
|
I will resolve the conflicts and merge this code. |
|
I could really use the issue API functions... I need to import a big list of issues from a different platform. |
implementing the issue api endpoint.
from #133